Skip to content

fix: Avoid dropping of tasks that don't fit in local queue #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NthTensor merged 1 commit into from
Dec 26, 2025
Merged

fix: Avoid dropping of tasks that don't fit in local queue #39

NthTensor merged 1 commit into from
Dec 26, 2025
+2 −2

Conversation

@davidlattimore
Copy link
Contributor

@davidlattimore davidlattimore commented Dec 1, 2025

No description provided.

@davidlattimore
Copy link
Contributor Author

davidlattimore commented Dec 1, 2025

This fixes a deadlock seen in the test scope::tests::scoped_concurrency. Where more than 64 jobs were spawned into a scope, the job queue for that worker would fill up. The remaining jobs would be discarded without being executed. When the scoped tried to finish, it would wait for all jobs to complete, which would never happen because some had been lost.

Issue #37

@NthTensor NthTensor merged commit 570defa into NthTensor:main Dec 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NthTensor NthTensor NthTensor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidlattimore @NthTensor